Best practices
Reviewing agent proposals
What to check before accepting a change an agent produced.
What you'll learn
A checklist for reviewing proposals from the planner, generator, healer and upgrader roles.
- Scope: the proposal touches only the module it was asked about. Reject anything that edits unrelated features or steps.
- Reuse: new steps exist only where the shared vocabulary has no match; check
step_findsuggestions in the manifest. - Locators: role, label or test id first; CSS only inside page objects with a heal context.
- Assertions: a heal proposal must not loosen an assertion; a generator proposal must assert an outcome, not just "no error".
- Tags: one layer, one suite, value tags valid; run
automax linton the proposal (accept does it for you). - Verification: the manifest records which scenarios the agent ran and their status; re-run them yourself on a second browser.
- Cost: note the model, turns and cost in the manifest; adjust
agents.budgetUsdwhen a role overspends. - Branch: accept with
--branchand open a pull request; never apply tomaindirectly.